Skip to content

Conversation

@Am6er
Copy link

@Am6er Am6er commented Mar 8, 2020

* absolute path issue for golangci-lint
* args issue

    * absolute path issue for golangci-lint
    * args issue
@kaste
Copy link
Member

kaste commented Mar 9, 2020

Please describe the "absolute path issue for golangci-lint". The change introduced would change the linter behavior from linting the path the current edited file is in to "just the file". If people want to change that (often?), maybe it should configurable. Other people might want to lint the whole project, or the path plus its subdirectories.

Adding ${args} is usually a good idea.

@Am6er
Copy link
Author

Am6er commented Mar 9, 2020

About "absolute path issue":
1.Clean version of ST. go version 1.14. golangci-lint current version. Mac OS current version.
2.Install via Package Control: SublimeLinter, SublimeLinter-golangcilint. Turn "debug":true in SublimeLinter.
3.Open any Go source, and recieve in ST console:

SublimeLinter: #1 linter.py:1636 Running ...

/Users/amber/Documents/GitHub/Test (working dir)
$ /Users/amber/go/bin/golangci-lint run --fast --out-format tab /Users/amber/Documents/GitHub/Test

SublimeLinter: #1 linter.py:786 WARNING: golangcilint output:
level=error msg="[runner/goanalysis_metalinter] typechecking error: import "/Users/amber/Documents/GitHub/Test": cannot import absolute path"
level=warning msg="[runner] Can't run linter goanalysis_metalinter: assign: failed prerequisites: inspect@/Users/amber/Documents/GitHub/Test"
level=error msg="Running error: assign: failed prerequisites: inspect@/Users/amber/Documents/GitHub/Test"

@cixtor
Copy link
Member

cixtor commented Mar 9, 2020

Thank you, can you please more run tests? For example, with a project using Go modules, with a project inside the deprecated GOPATH directory, with a project using a vendor folder. The more tests the better. I agree with Kaste, it is better to be cautious with these changes.

@cixtor
Copy link
Member

cixtor commented Jul 25, 2025

Closing pull-request as obsolete after 1,903 days of inactivity from @Am6er . Thanks for your contribution anyway.

@cixtor cixtor closed this Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants