Skip to content

Conversation

@remos
Copy link
Contributor

@remos remos commented Aug 4, 2014

I think tab_width should be specified as the default for more linters.
Is there a reason tab_width isn't specified more often?

Considering that SublimeLinter already parses the reported visual column number to a character column number, it makes sense to me to set the tab_width to the default of the linter itself.
This way, regardless of a person's tab settings the regions should be in the same position. (Only if they change the linter's tab_size setting would it misalign)

Here's an example of it without tab_width where the regions should only be marking the '<'s:
Example of mis-aligned regions

After setting tab_width it works fine.

@aparajita
Copy link
Contributor

Is there a reason tab_width isn't specified more often?

I guess I'm just lazy. Too much sitting around writing software for free so others can benefit and then complain that I don't do enough.

aparajita added a commit that referenced this pull request Aug 4, 2014
Added tab_width to linter.py
@aparajita aparajita merged commit 838af15 into SublimeLinter:master Aug 4, 2014
@remos
Copy link
Contributor Author

remos commented Aug 4, 2014

I wasn't meaning to complain. I was genuinely curious if there was some reason I hadn't thought of.
SublimeLinter's terrific. I as well as I'm sure everyone who uses it, really appreciates all the time you've put into it.

Cheers.

@aparajita
Copy link
Contributor

I was genuinely curious if there was some reason I hadn't thought of.

I don't use (and didn't write) every linter, and the ones I use are working fine. I just don't have time to go through every linter and figure out what the tab width should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants