Skip to content

Conversation

@braver
Copy link
Member

@braver braver commented Jun 6, 2020

Granted, the error codes are a bit long...

Screen Shot 2020-06-06 at 22 51 26

and capture it in the regex
@braver braver requested a review from kaste June 6, 2020 20:52
@kaste
Copy link
Member

kaste commented Jun 6, 2020

More than 40 chars is excessive. Do you think people will appreciate that change?

@braver
Copy link
Member Author

braver commented Jun 6, 2020

I would 😅 it’s kinda nice to be able find the error codes easily. Anyway, I can probably make it optional, but then our nice ignore feature won’t work on a per-code basis unless you enable it.

@braver
Copy link
Member Author

braver commented Jun 7, 2020

Regexes are stupid. We should have tests for these things...

Anyway, this should allow users to enable the error codes by add -s to the args, but leave it unchanged otherwise.

@braver
Copy link
Member Author

braver commented Sep 5, 2020

I've been using this for ages and it works. Enabling capture of the error code, and thereby enabling quick actions, is super useful.

@braver braver merged commit 9bfdf22 into master Sep 5, 2020
@kaste
Copy link
Member

kaste commented Sep 5, 2020

Yeah sure; don't forget to release. A short message would be nice so users actually know about this feature.

@kaste kaste deleted the error-codes branch September 5, 2020 19:41
@braver
Copy link
Member Author

braver commented Sep 5, 2020

My mind wandered and I was indeed about to forget all about it 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants