Skip to content

Iterate #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 11, 2018
Merged

Iterate #23

merged 3 commits into from
May 11, 2018

Conversation

@kaste
Copy link
Member

@kaste kaste commented May 11, 2018 •
edited
Loading

  • Handle stderr output
  • Match near

Fixes #22

@kaste
Copy link
Member Author

kaste commented May 11, 2018

https://regex101.com/r/D7wUyz/1/

@kaste kaste requested a review from braver May 11, 2018 13:15
@braver
Copy link
Member

braver commented May 11, 2018

Looks good and works good, althout I don't have a real opinion about the solution for #22. "I guess so" would be my reaction, which is good enough. 😄 🚢 it!

@kaste kaste merged commit cf9c237 into master May 11, 2018
@kaste kaste deleted the iterate branch May 11, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@braver braver Awaiting requested review from braver

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kaste @braver