Opt-in to python 3.8 #152
Merged
Opt-in to python 3.8 #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit... 1. opts-in Helium to python 3.8 2. adjusts dependencies for python 3.8 plugin_host - "enum" is now built-in and no longer needed - "pyzmq" 26 however requires "tornado" library
Remove ST version number.
|
Collaborator
|
Hey, thanks for your PR! I'm not using sublime text anymore, so sadly I cannot test the PR. Does Helium still work with ST3? |
Member
Author
|
This PR doesn't change anything for ST3. It only marks the plugin to run on python 3.8 in ST4, primarily to use latest pyzmq library and support arm64 platforms. |
Collaborator
|
Closes #150 |
Member
Author
|
FWIW, this PR was created together with yaroslavyaroslav. He confirmed Helium working on ST4 MacOS M1. |
cgahr
reviewed
Aug 5, 2024
Closed
cgahr
approved these changes
Aug 5, 2024
Member
Author
|
Thanks for your efforts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146
Fixes #150
This PR...
This change fixes compatibility with Apple Silicon and Linux ARM64.
Note: These are least required changes. I see some Syntax Warnings in console. Maybe a bit more action needst to be taken to fully support python 3.8