Skip to content

Move the settings menu entry in the proper submenu#15

Merged
michaelblyons merged 2 commits intoSublimeText:masterfrom
Frizlab:fix/frizlab/settings_location
Mar 24, 2026
Merged

Move the settings menu entry in the proper submenu#15
michaelblyons merged 2 commits intoSublimeText:masterfrom
Frizlab:fix/frizlab/settings_location

Conversation

@Frizlab
Copy link
Contributor

@Frizlab Frizlab commented Mar 23, 2026

Note: I put an ellipsis to the Settings… menu entry. This is a common thing on macOS: menu entries that open a window should end with an ellipsis.

I can revert that particular change if needed.

@braver
Copy link
Member

braver commented Mar 24, 2026

It's common but not very consistent even in core OS features 😉 (both "About" and "System settings...." open windows).

Scherm­afbeelding 2026-03-24 om 17 04 26

Typically it's meant to indicate nothing is changed until the user takes another step. So ... means a dialog or some choice will be opened as a way of saying "don't worry about clicking this, it's not final". In that way it's common in all operating systems. Sublime Text packages pretty much never have the ellipsis on settings and keybinding entries in the menu, so here it might actually stand out as different ("what's going on here") and you're fine without.

@Frizlab
Copy link
Contributor Author

Frizlab commented Mar 24, 2026

Oh yeah I never noticed the About does not have the ellipsis. Anyways, in order not to stand out, I’m removing the ellipsis now!

Most packages do not have it; let’s blend in.
@michaelblyons michaelblyons merged commit 7d28b14 into SublimeText:master Mar 24, 2026
3 checks passed
@Frizlab Frizlab deleted the fix/frizlab/settings_location branch March 24, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants