Skip to content

Always start coverage after reloading #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deathaxe merged 1 commit into from
Apr 2, 2024
Merged

Always start coverage after reloading #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ UnitTesting could be configured by providing the following settings in `unittest
| show_reload_progress | print a detailed list of reloaded modules to console | false |
| coverage | track test case coverage | false |
| coverage_on_worker_thread | (experimental) | false |
| start_coverage_after_reload | self explained, irrelevent if `coverage` or `reload_package_on_testing` are false | false |
| generate_html_report | generate HTML report for coverage | false |
| generate_xml_report | generate XML report for coverage | false |

Expand Down
1 change: 0 additions & 1 deletion unittesting/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
"show_reload_progress": False,
# coverage
"coverage": False,
"start_coverage_after_reload": False,
"coverage_on_worker_thread": False, # experimental
"generate_html_report": False,
"generate_xml_report": False,
Expand Down
13 changes: 4 additions & 9 deletions unittesting/unit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,13 @@ def run(self, package=None, **kwargs):
self.run_coverage(package, stream, settings)

def run_coverage(self, package, stream, settings):
if settings["reload_package_on_testing"]:
reload_package(package)

if not coverage or not settings["coverage"]:
if settings["coverage"]:
stream.write("Warning: coverage cannot be loaded.\n\n")

if settings["reload_package_on_testing"]:
reload_package(package, verbose=settings["show_reload_progress"])

self.run_tests(stream, package, settings, [])
return

Expand Down Expand Up @@ -136,12 +136,7 @@ def run_coverage(self, package, stream, settings):
data_file=data_file, config_file=config_file, include=include, omit=omit
)

if not settings["start_coverage_after_reload"]:
cov.start()
if settings["reload_package_on_testing"]:
reload_package(package, verbose=settings["show_reload_progress"])
if settings["start_coverage_after_reload"]:
cov.start()
cov.start()

if settings["coverage_on_worker_thread"]:
import threading
Expand Down