Fix script/style/template indentation #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit backports sublimehq/Packages#4020 to ensure related indentation rules are correctly applied for ST4181+. Scope changes are backported primarily due to their effect on syntax tests and the goal to avoid a need to ship dedicated ST4181+ releases just due to failing syntax tests, which do otherwise not have any significant effect on highlighting.
In order to properly handle `<template>` tag indentation in combination with script/style comment handling dedicated indentation rules are required. This commit therefore backports and adjusts indentation rules from sublimehq/Packages#4020
Member
Author
|
Actually I am uncertain, whether we really need the complicated comment handling in If we don't need it, we could probably simplify this PR and remove script/style related stuff in a following ST4126+ PR and let indentation be fixed by builtin HTML for ST4180+ |
This commit 1. removes special treatment of html comments wrapping template content as this is supported by browsers primarily for legacy code. 2. removes indentation rules and makes syntax tests more lazy to avoid them fail across various ST versions. As a result Vue completely relies on ST's indentation rules, which means it works best as of ST4180.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit backports sublimehq/Packages#4020 to ensure related indentation rules are correctly applied for ST4181+.
Scope changes are backported primarily due to their effect on syntax tests and the goal to avoid a need to ship dedicated ST4181+ releases just due to failing syntax tests, which do otherwise not have any significant effect on highlighting.