Change label indexing#39
Merged
keith-hall merged 1 commit intomasterfrom Dec 18, 2025
Merged
Conversation
to use suffices, in case of embedding
keith-hall
approved these changes
Dec 17, 2025
Member
keith-hall
left a comment
keith-hall
left a comment
There was a problem hiding this comment.
Would it make sense to have some common scope suffix in addition to the current one, to make these tmPreferences easier and not need to change when we add support for more pipelines? Or too unusual and not worth it?
Contributor
Author
|
I don't think it's a big issue. The only time I imagine this coming up is adding a new syntax but forgetting the indexing change. FWIW, there might already be more pipelines that could be indexed. Drone seems to have named steps. Azure has |
FichteFoll
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change label indexing to use suffices, in case of embedding.
See #38