Skip to content

Various fixes for sublime_plugin stubs. #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Thom1729 merged 5 commits into from
Apr 19, 2021
Merged

Various fixes for sublime_plugin stubs. #167

Thom1729 merged 5 commits into from
Apr 19, 2021

Conversation

@Thom1729
Copy link
Member

@Thom1729 Thom1729 commented Apr 16, 2021

Based on comments in #160:

  • Make CommandInputHandler generic.
  • Offer overload for confirm() with event.
  • Broaden type for run().

jfcherng added a commit to jfcherng-sublime/ST-API-stubs that referenced this pull request Apr 16, 2021
@jfcherng
fix: changes from SublimeText/sublime_lib#167
7195011 
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
@gwenzek
Copy link

gwenzek commented Apr 16, 2021 •
edited
Loading

Looks good to me :-)

FichteFoll
FichteFoll reviewed Apr 16, 2021
View reviewed changes
@Thom1729
Copy link
Member Author

Thom1729 commented Apr 17, 2021

Other improvements:

  • Remove the unnecessary inheritance clauses.
  • meta_info returns dict, not str.
  • on_X_command can return None.
  • on_query_context returns Optional[bool], not Optional[None].
  • Use more specific return type for on_query_completions.

jfcherng added a commit to jfcherng-sublime/ST-API-stubs that referenced this pull request Apr 19, 2021
@jfcherng
fix: some return types
749ea09 
SublimeText/sublime_lib#167 (comment)

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
jfcherng added a commit to jfcherng-sublime/ST-API-stubs that referenced this pull request Apr 19, 2021
@jfcherng
fix: some return types
f9ea4f5 
SublimeText/sublime_lib#167 (comment)

Signed-off-by: Jack Cherng <jfcherng@gmail.com>
@Thom1729 Thom1729 merged commit 239cb58 into master Apr 19, 2021
@Thom1729 Thom1729 deleted the sublime-plugin-stub-fixes branch April 19, 2021 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FichteFoll FichteFoll FichteFoll approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Thom1729 @gwenzek @FichteFoll