Conversation
As usage of `Value` is gated by `TYPE_CHECKING` and disabled evaluation of annotations, it is safe to use sublime_types.Value without breaking runtime code of ST builds before 4135. It would just be type checkers, complaining about missing imports, when executed on such old builds, which is considered acceptable in favor of less duplicate definitions. FWIW, it has already been used by window_utils, this way.
FichteFoll
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to somewhat improve type hints of functions from
_utils.collectionsmodule.To avoid circular imports,
Valuedefinition is moved from settings_dict to _utils.collections.Calls of
get_selectoretc. are marked# type: ignoreasSettingsDictdoesn't fully implementMappingprotocol.