Merged
Conversation
This commit replaces _running & _invocation_id by _state attribute, to ensure only single _tick being in flight.
deathaxe
force-pushed
the
feat/activity-indicator-statemachine
branch
from
fd005ec to
ae6c9e3
Compare
This commit converts _tick() method, bound to instance, into a weak method in order to avoid re-creating a weakref each tick.
FichteFoll
reviewed
Feb 13, 2026
deathaxe
force-pushed
the
feat/activity-indicator-statemachine
branch
from
3d9fb36 to
09ddeaa
Compare
Mypy complains about inplace replacement of bound methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements a state machine to ensure only single
_tick()being in flight viasublime.set_timeout().It replaces
_running&_invocation_idby_stateattribute, to indicate required states, especially the "STOPPING" one.