Possible false positive warnings about invalid `syntax_test_` files.

[deathaxe]

This action seems to print invalid warnings about malformed syntax_test files being present.

Example:

Syntax Tests (latest, master): ./Package/Property#L0
Syntax test filenames must begin with 'syntax_test_'

see: https://github.com/SublimeText/PackageDev/actions/runs/24145702504

Likely causing code:

syntax-test-action/syntax-tests.sh

Lines 141 to 151 in 20adb50

	echo "::group::Checking syntax test filenames"
	for path in $(find . -iname syntax_test*); do
	file="${path/$packages\/$INPUT_PACKAGE_NAME/$INPUT_PACKAGE_ROOT}"
	if echo "$file" | grep -v '/syntax_test_'; then
	echo "::warning file=$file::Syntax test filenames must begin with 'syntax_test_'"
	fi
	if head -n 1 "$path" | grep -vEq '.+\bSYNTAX TEST\b.+".+\.(sublime-syntax|tmLanguage)"'; then
	echo "::warning file=$file::Syntax test file format at https://www.sublimetext.com/docs/syntax.html#testing"
	fi
	done
	echo '::endgroup::'

[michaelblyons]

These are intentional. See #26 (particularly #26 (comment)), #27, sublimehq/Packages#4057, and SublimeText/PackageDev#247

[michaelblyons]

Oh, you mean it's flagging the wrong files. Yes, that's a mistake.

[deathaxe]

I would expect those warnings, only if there were malformed test files present in tested repository. Do you find any in PackageDev? At least the run against master shouldn't print warnings.

[michaelblyons]

Ah, maybe it broke on spaces in filenames.

./Package/TextMate
  Warning: Syntax test filenames must begin with 'syntax_test_'
  head: cannot open './Package/TextMate' for reading: No such file or directory
  head: cannot open 'Preferences/syntax_test_tmPreferences.xml' for reading: No such file or directory

instead of ./Package/TextMate Preferences/syntax_test_tmPreferences.xml.

That is my fault.

[michaelblyons]

Is it okay for me to cut a 2.5.1 release, or do you or @FichteFoll want to double-check?

[FichteFoll]

I'll do it.