Skip to content

Conversation

@sbelsk
Copy link
Member

@sbelsk sbelsk commented Jul 19, 2021

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added/updated (if possible)
  • Documentation has been updated/added if relevant

What is the current behavior?

There is currently no testing for /bin/hash_all.py

What is the new behavior?
This PR adds basic tests for the file, which can be run manually from a vagrant machine, and also the GitHub Actions testing.

Other information?
This PR relies on the infrastructure set by PR #40 to run the unit tests and connect them to GitHub Actions, so this PR can only be merged after it.

@sbelsk sbelsk requested a review from williamjallen July 19, 2021 20:20
@bmcutler bmcutler merged commit 39f7862 into main Jul 22, 2021
@bmcutler bmcutler deleted the hash-all-tests branch July 22, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants