[Refactor:Plagiarism] Move error checks to concatenate_all.py #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements:
What is the current behavior?
Error checking is currently done in many different places throughout Lichen and is typically only done on parameters just before they are used. This means that it is possible to fail a basic assertion after completing an expensive operation.
What is the new behavior?
The relevant error checks that are not affected by the progress of the Lichen processes and can be done ahead of time are done immediately in
concatenate_all.pyinstead of waiting until just before each parameter is used.This change is also relevant for a future refactor discussed with @bmcutler involving sending zipped Lichen config directories to worker machines.
Other information?
No breaking changes. Everything should still work as before.