Skip to content

Conversation

@williamjallen
Copy link
Member

@williamjallen williamjallen commented Jul 28, 2021

What is the current behavior?

The C, Java, and Python tokenizers are currently broken and thus, no tests have been written for them. The primary source of the issue is a lack of installed dependencies on Submitty and outdated python versions listed in data.json.

What is the new behavior?

This PR fixes the afflicted tokenizers and adds tests for them. In addition, the installation of all dependencies necessary to run Lichen has been moved into the install_lichen.sh script. A list of python dependencies has been made in requirements.txt. After this PR, all of the supported tokenizers will be working and will be fully tested.

Fixes Submitty/Submitty#6611
Fixes Submitty/Submitty#2134

@bmcutler bmcutler merged commit 678906d into main Jul 30, 2021
@bmcutler bmcutler deleted the add-requirements-to-install branch July 30, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lichen Java Tokenizer is Broken Lichen C Tokenizer cannot run under python3

4 participants