-
Notifications
You must be signed in to change notification settings - Fork 909
[Dependency] Bump watchdog from 4.0.1 to 6.0.0 in /.setup/pip #11114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11114 +/- ##
=========================================
Coverage 20.82% 20.82%
Complexity 9115 9115
=========================================
Files 261 261
Lines 34966 34966
Branches 460 460
=========================================
Hits 7280 7280
Misses 27230 27230
Partials 456 456
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
7c8aeb5 to
a69c607
Compare
|
This PR appears to break the code watcher script: |
|
@dependabot rebase |
a69c607 to
470fd23
Compare
|
@williamjallen The failure was being caused by a breaking change in version 5.0.0 that enforces keyword arguments. See feat!: more typing clean-up + enforce keyword-arguments #1057. Prior to this release, Watchdog could interpret the third value of observer.schedule as |
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
|
@dependabot recreate |
Bumps [watchdog](https://github.com/gorakhargosh/watchdog) from 4.0.1 to 6.0.0. - [Release notes](https://github.com/gorakhargosh/watchdog/releases) - [Changelog](https://github.com/gorakhargosh/watchdog/blob/master/changelog.rst) - [Commits](gorakhargosh/watchdog@v4.0.1...v6.0.0) --- updated-dependencies: - dependency-name: watchdog dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
4115702 to
c3c4838
Compare
Same changes as before the recreate. I verified that the daemon handler is still working correctly
williamjallen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JManion32 Have you verified that the usage in sbin/submitty_daemon_jobs/submitty_jobs/handler.py works properly? That case is far more important than the code watcher because it affects production usage.
I verified multiple times that |
Bumps watchdog from 4.0.1 to 6.0.0.
Release notes
Sourced from watchdog's releases.
... (truncated)
Changelog
Sourced from watchdog's changelog.
... (truncated)
Commits
76c091dVersion 6.0.058386d8Fixes, and clean-up (#1084)db698a5fix: reading inotify file descriptor after closing it. (#1081)73d5612[docs] Add typing info to quick start (#1082)d774fecdocs: Update README Badges (#1083)6b74737docs: funding3d1b888[inotify] Use ofselect.poll()instead of deprecatedselect.select()(#1078)6a4f1cfBump the versionad6df50Version 5.0.359650f8fix: polish #1070You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)