Skip to content

Conversation

@JManion32
Copy link
Contributor

In colors.css, there were 14 colors not being used anywhere in the project. I deleted them and verified that Submitty's UI in light mode and dark mode remained unchanged.

Removed all unused colors in colors.css
@codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.09%. Comparing base (c4dab15) to head (3f71191).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #11433   +/-   ##
=========================================
  Coverage     22.09%   22.09%           
  Complexity     8835     8835           
=========================================
  Files           246      246           
  Lines         31805    31805           
  Branches         79       79           
=========================================
  Hits           7026     7026           
  Misses        24703    24703           
  Partials         76       76           
Flag Coverage Δ
autograder 21.56% <ø> (ø)
js 26.85% <ø> (ø)
migrator 100.00% <ø> (ø)
php 19.09% <ø> (ø)
python_submitty_utils 80.08% <ø> (ø)
submitty_daemon_jobs 90.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@JManion32 JManion32 changed the title [Refactor:UI] Remove Unused Colors from colors.css [Refactor:System] Remove Unused Colors from colors.css Feb 4, 2025
Copy link
Contributor

@hinyan17 hinyan17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that the colors were not used anywhere else in Submitty. UI looks the same in light and dark mode too.

Copy link
Contributor

@max1dyer max1dyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified all colors removed are not used in any other files. The site looks the same in light and dark mode. Some hex color codes are used for multiple color variables but since the other colors are currently being used that shouldn't matter.

@williamjallen williamjallen merged commit 443df76 into main Feb 4, 2025
23 of 24 checks passed
@williamjallen williamjallen deleted the pr-remove-unused-colors branch February 4, 2025 21:16
lllinging pushed a commit to lllinging/Submitty that referenced this pull request Feb 6, 2025
In colors.css, there were 14 colors not being used anywhere in the
project. I deleted them and verified that Submitty's UI in light mode
and dark mode remained unchanged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants