Skip to content

Conversation

@MasterOdin
Copy link
Member

@MasterOdin MasterOdin commented Mar 5, 2019

This is a rather large PR as it aims to fix a bunch of things in the pursuit of the singular task of "make the tests pass and have Github stop complaining about security bug in dependencies". (Note: much of the size of this PR is actually in updating saved copies of some of the dependencies in the shared folder).They are:

  • Update all dependencies to latest versions
  • Move the usage of "userId" to be self-contained within the LocalStoreAdapter and fix the broken inheritance model of StoreAdapter by LocalStoreAdapter which was causing a whole class of bugs with creating/editing/deleting annotations and comments.
  • Fix being able to move annotations around the screen when using the cursor
  • Fix not being able to delete icons when hitting "Delete" when selected on with cursor
  • Add being able to hit "Backspace" to delete an element when selected on with cursor
  • Disable being able to move paths until the logic is fixed
  • Turn off trimming of left side of text (closes PDF Annotator text tool trims Submitty#2990)
  • Test PointerEvents for drawing on both Firefox and Chrome (and all other browsers) instead of just on Firefox and falling back to combination of Mouse/Touch for Chrome (needs further testing once I get a tablet in)
  • Turn on testing of both Firefox and Chrome in Travis
  • Bugfixes for having the color names be shown on the web test
  • Add "eraser icon" to web test next to existing cursor icon
  • Limit deletion via cursor + backspace/delete/x-icon to be only for current user's annotations
  • Allow flag within Store to allow deletion of any user's annotatations
  • Add tests for eraser

@MasterOdin MasterOdin marked this pull request as ready for review March 6, 2019 06:16
@MasterOdin MasterOdin merged commit 3d122aa into master Mar 7, 2019
@MasterOdin MasterOdin deleted the refactor branch April 19, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PDF Annotator text tool trims

2 participants