refactor: remove parent task key#554
Merged
Merged
Conversation
2 tasks
guilhem-barthes
requested review from
AlexandrePicosson,
AurelienGasser,
Kelvin-M,
Milouu,
ThibaultFy,
cboillet-dev,
mblottiere,
oleobal,
samlesu and
sergebouchut2
as code owners
ThibaultFy
approved these changes
Jan 2, 2023
guilhem-barthes
added a commit
to Substra/orchestrator
that referenced
this pull request
Jan 9, 2023
## Companion PR - Substra/substra-backend#554 ## Description - Remove `compute_task_parents`: - in `ComputeTask` - in gRPC communication - remove `expanded_compute_tasks` ## How has this been tested? CI ## Checklist - [x] [changelog](../CHANGELOG.md) was updated with notable changes - [ ] documentation was updated Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
guilhem-barthes
force-pushed
the
feat/remove-parent_task_key
branch
from
5f82246 to
2e6291f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR
Description
Remove
parent_tasksinComputeTaskin Django models and update gRPC to removecompute_task_keyinComputeTaskHow has this been tested?
CI in orchestrator
Checklist