Skip to content

feat: Change tasks & steps duration format in task profiling to microseconds#598

Merged
Milouu merged 2 commits into
mainfrom
feat/task-duration-format
Feb 21, 2023
Merged

feat: Change tasks & steps duration format in task profiling to microseconds#598
Milouu merged 2 commits into
mainfrom
feat/task-duration-format

Conversation

@Milouu
Copy link
Copy Markdown
Contributor

@Milouu Milouu commented Feb 20, 2023

Description

Change durations format to microseconds for task duration & execution rundown steps in task profiling.

Companion PR : Substra/substra-frontend#165

Checklist

  • changelog was updated with notable changes
  • documentation was updated

@Milouu Milouu requested a review from a team as a code owner February 20, 2023 14:22
@github-actions github-actions Bot added the api label Feb 20, 2023
@Milouu Milouu force-pushed the feat/task-duration-format branch from 81f8e26 to 591279a Compare February 20, 2023 14:26
@Milouu Milouu changed the title Change tasks & steps duration format in task profiling to microseconds feat: Change tasks & steps duration format in task profiling to microseconds Feb 20, 2023
@Milouu Milouu force-pushed the feat/task-duration-format branch 2 times, most recently from 69338be to c2f2877 Compare February 20, 2023 14:33
@Milouu
Copy link
Copy Markdown
Contributor Author

Milouu commented Feb 20, 2023

/e2e

@Owlfred
Copy link
Copy Markdown

Owlfred commented Feb 20, 2023

End to end tests: ❌ FAILURE

Jobs status:

  • Tests Benchmark: ⏭️
  • Tests Distributed:
  • Tests Standalone:

“Rien ne sert de courir ; il faut partir à point.” ― Jean de La Fontaine (Le Lièvre et la Tortue)

@Milouu Milouu force-pushed the feat/task-duration-format branch from c2f2877 to d398b6d Compare February 20, 2023 14:36
…seconds

Signed-off-by: Milouu <milan.roustan@owkin.com>
@Milouu Milouu force-pushed the feat/task-duration-format branch from 0e2e15f to aeef5d7 Compare February 21, 2023 13:57
@Milouu
Copy link
Copy Markdown
Contributor Author

Milouu commented Feb 21, 2023

/e2e

@Owlfred
Copy link
Copy Markdown

Owlfred commented Feb 21, 2023

End to end tests: ❌ FAILURE

Not this time.

@Milouu Milouu force-pushed the feat/task-duration-format branch 2 times, most recently from 05300b1 to 0efc14e Compare February 21, 2023 14:41
@Milouu
Copy link
Copy Markdown
Contributor Author

Milouu commented Feb 21, 2023

/e2e

@Owlfred
Copy link
Copy Markdown

Owlfred commented Feb 21, 2023

End to end tests: ✔️ SUCCESS

Signed-off-by: Milouu <milan.roustan@owkin.com>
@Milouu Milouu force-pushed the feat/task-duration-format branch from 0efc14e to 5124895 Compare February 21, 2023 14:46
Copy link
Copy Markdown
Contributor

@guilhem-barthes guilhem-barthes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Milouu Milouu merged commit 3db5fea into main Feb 21, 2023
@Milouu Milouu deleted the feat/task-duration-format branch February 21, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants