chore: remove ComputeTask pre GT links#614
Merged
Merged
Conversation
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
guilhem-barthes
changed the title
TaskDataSample
guilhem-barthes
changed the title
ComputeTask pre GT links
Contributor
Author
|
/e2e --tests sdk,frontend,substrafl --benchmarks mnist,camelyon |
|
End to end tests: ✔️ SUCCESS |
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
SdgJlbl
reviewed
Mar 17, 2023
SdgJlbl
reviewed
Mar 17, 2023
SdgJlbl
approved these changes
Mar 17, 2023
Contributor
SdgJlbl
left a comment
SdgJlbl
left a comment
There was a problem hiding this comment.
I asked a couple questions because I'm still unsure about the nuts and bolts, but LGTM
Thanks for the cleaning up! 🧹
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
oleobal
approved these changes
Mar 23, 2023
ThibaultFy
reviewed
Mar 23, 2023
| @@ -23,7 +23,6 @@ | |||
| ... ), | |||
| ... outputs=factory.build_computetask_outputs(function), | |||
| ... data_manager=data_manager, | |||
Member
There was a problem hiding this comment.
Suggested change
| ... data_manager=data_manager, |
| @@ -45,7 +44,6 @@ | |||
| ... ), | |||
| ... outputs=factory.build_computetask_outputs(metric), | |||
| ... data_manager=data_manager, | |||
Member
There was a problem hiding this comment.
Suggested change
| ... data_manager=data_manager, |
| @@ -125,9 +124,6 @@ class ComputePlanFilter(FilterSet): | |||
| ) | |||
| function_key = CharFilter(field_name="compute_tasks__function__key", distinct=True, label="function_key") | |||
| dataset_key = CharFilter(field_name="compute_tasks__data_manager__key", distinct=True, label="dataset_key") | |||
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Contributor
Author
|
/e2e --tests sdk,frontend,substrafl --benchmarks mnist,camelyon |
|
End to end tests: ✔️ SUCCESS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR
ComputeTaskpr-GT links substra-frontend#182Description
Generic task moved some of the entities linked with a compute task to
ComputeTaskInputAsset/ComputeTaskOutputAsset. In this case,DataSampleandDataManagerare now used throughComputeTaskInputAsset.How has this been tested?
CI
Checklist