Skip to content

chore: refactor input loop in get_exec_command_args#615

Merged
guilhem-barthes merged 3 commits into
mainfrom
chore/refactor-inputs-loop
Mar 24, 2023
Merged

chore: refactor input loop in get_exec_command_args#615
guilhem-barthes merged 3 commits into
mainfrom
chore/refactor-inputs-loop

Conversation

@guilhem-barthes
Copy link
Copy Markdown
Contributor

@guilhem-barthes guilhem-barthes commented Mar 21, 2023

Description

Refactor 3 loops on inputs in substrapp in only one

How has this been tested?

CI

Checklist

  • changelog was updated with notable changes
  • documentation was updated

Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
@guilhem-barthes
Copy link
Copy Markdown
Contributor Author

/e2e --tests sdk,substrafl,frontend

@Owlfred
Copy link
Copy Markdown

Owlfred commented Mar 21, 2023

End to end tests: ✔️ SUCCESS

That was easy.

@guilhem-barthes guilhem-barthes marked this pull request as ready for review March 22, 2023 09:54
@guilhem-barthes guilhem-barthes requested a review from a team as a code owner March 22, 2023 09:54
Copy link
Copy Markdown
Contributor

@SdgJlbl SdgJlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Contributor

@oleobal oleobal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Comment thread backend/substrapp/compute_tasks/command.py
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Copy link
Copy Markdown
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ! :)

@guilhem-barthes
Copy link
Copy Markdown
Contributor Author

/e2e --tests sdk,substrafl,frontend

@Owlfred
Copy link
Copy Markdown

Owlfred commented Mar 24, 2023

End to end tests: ❌ FAILURE

Jobs status:

  • Tests Benchmark: ⏭️
  • Tests Distributed:
  • Tests Standalone:

“Success is not final; failure is not fatal: It is the courage to continue that counts.” ―- Winston S. Churchill

@guilhem-barthes
Copy link
Copy Markdown
Contributor Author

/e2e --tests sdk,frontend,substrafl --benchmarks mnist,camelyon

@Owlfred
Copy link
Copy Markdown

Owlfred commented Mar 24, 2023

End to end tests: ✔️ SUCCESS

@guilhem-barthes guilhem-barthes merged commit 2765037 into main Mar 24, 2023
@guilhem-barthes guilhem-barthes deleted the chore/refactor-inputs-loop branch March 24, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants