feat: allow retries on task profiling steps#691
Merged
guilhem-barthes merged 10 commits intoAug 3, 2023
Conversation
FL-496 [BUG] call to task profiling POST endpoint triggers a 500
Context and user need: logs (full logs in comment): unicity constraint violation on (compute_task_profile_id, step) possibly in the context of a task being retried following an initial, unrelated incident (OOM killed is probable) Functional spec: Technical spec: Acceptance criteria: |
guilhem-barthes
changed the title
guilhem-barthes
force-pushed
the
feat/allow-retries-on-task-profiling-steps
branch
from
c560b16 to
9e9e7a4
Compare
Contributor
Author
|
/e2e |
|
End to end tests: ✔️ SUCCESS Nailed it! |
SdgJlbl
reviewed
Jul 18, 2023
Contributor
SdgJlbl
left a comment
SdgJlbl
left a comment
There was a problem hiding this comment.
Thanks for the PR
I have a few questions to be sure to understand how things are unfolding now :)
guilhem-barthes
force-pushed
the
feat/allow-retries-on-task-profiling-steps
branch
from
4e074f5 to
b64d380
Compare
Contributor
Author
|
/e2e |
|
End to end tests: ✔️ SUCCESS Yay! 🎉 |
SdgJlbl
reviewed
Jul 26, 2023
SdgJlbl
reviewed
Jul 26, 2023
| raise e | ||
|
|
||
|
|
||
| @retry() |
Contributor
There was a problem hiding this comment.
TIL we have reimplemented our very own retry decorator
guilhem-barthes
force-pushed
the
feat/allow-retries-on-task-profiling-steps
branch
from
b64d380 to
b889a53
Compare
Contributor
Author
|
/e2e |
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
Signed-off-by: Guilhem Barthes <guilhem.barthes@owkin.com>
guilhem-barthes
force-pushed
the
feat/allow-retries-on-task-profiling-steps
branch
from
b889a53 to
131009b
Compare
Contributor
Author
|
/e2e |
|
End to end tests: ✔️ SUCCESS “I love it when a plan comes together.” ― Colonel John “Hannibal” Smith, The A-Team |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
(4 first commits are refactoring to
pytest)Fixes FL-496
How has this been tested?
Checklist