This repository was archived by the owner on Sep 6, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Add channel name in chaincode log in case of multi-channels #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| func main() { | ||
| logger.SetFormatter(&logrus.TextFormatter{ | ||
| ForceColors: true, |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
AurelienGasser
approved these changes
Nov 25, 2020
Contributor
AurelienGasser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition
Contributor
|
@Kelvin-M the last commit makes the code hard to read, maybe introduce a |
1d1d176 to
f429ac9
Compare
Contributor
|
@Kelvin-M please take a look at my latest changes, it'f that's OK with you I think we can merge. |
inelgnu
approved these changes
Nov 30, 2020
Member
inelgnu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In case we use the same chaincode for multiple channel, like Substra/hlf-k8s#102, we need to log the channel name for each request to be able to review logs in case of troubleshooting sessions.
Closes issue(s)
None
Companion PRs
Substra/hlf-k8s#102
How to test / repro
Launch e2e tests (minimal) and look for chaincode logs :)
Screenshots / Trace
Changes include
Args receivedlog lineResponse from chaincodelog lineChecklist
Other comments
Feel free to change the format if you want to log it in a clearer way !