This repository was archived by the owner on Sep 6, 2022. It is now read-only.
Merged
Conversation
e041253 to
ae4e9b5
Compare
Contributor
Author
|
Running I'll try a new approach: lint before the build, but try building even if linting fails. |
Contributor
Author
|
Looks like it works:
I'll remove the intentional lint errors. |
added 4 commits
December 2, 2019 16:54
Contributor
Author
|
This is ready for review. Sorry for the noise ! |
Contributor
Author
|
Today I learned: adding |
"colon followed by space" is parsed as YAML syntax.
thibaultrobert
approved these changes
Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Lint only our modules:
golintdoesn't lint theerrors/package.golint ./...lints thevendors/package, which is wrong too.go listwith a grep in order to lint only the packages we wrote2. Try building the chaincode even if linting fails
Rationale: I assume it's always interesting to see if the package can build, even if linting failed.