Skip to content
This repository was archived by the owner on Sep 6, 2022. It is now read-only.

remove internal-only link#59

Merged
AurelienGasser merged 1 commit intomasterfrom
AurelienGasser-patch-1
Feb 24, 2020
Merged

remove internal-only link#59
AurelienGasser merged 1 commit intomasterfrom
AurelienGasser-patch-1

Conversation

@AurelienGasser
Copy link
Contributor

What do you think of removing this link that 404s for people who don't have access to the private repo substra-specs?

Comment on lines -32 to -34

Note for internal use only: See the [technical specifications](https://github.com/SubstraFoundation/substra-spec/blob/master/technical_spec_substra.md#smartcontract).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

substra-doc is now a legacy repo ;) The user doc is located in the substra repo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot about that. So let's send him to substra then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thibaultrobert What should the text for the link say?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well my first guess would be https://github.com/SubstraFoundation/substra but maybe @natct10 has a better suggestion as to where we can find Substra documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thibaultrobert Sorry, I meant which text should we add a link to? like [what do we put here???](some_link_to_susbtra)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok Mondays and I don't agree with each others.... [Substra main repository] ?
But at this point I would rather agree with the current state of the PR and remove that part completely. Maybe add a link to Substra but not as a Note for internal use only. So let me approve that for you and sorry for the noise

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, a small piece of documentation related to smart contracts is on its way (but not ready yet!), what do you think about temporarily removing this internal link & redirecting towards the general doc and update this part later?

@Kelvin-M
Copy link
Contributor

@AurelienGasser Any update on this one ?

@AurelienGasser AurelienGasser merged commit 7ea953a into master Feb 24, 2020
@AurelienGasser AurelienGasser deleted the AurelienGasser-patch-1 branch February 24, 2020 15:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants