This repository was archived by the owner on Sep 6, 2022. It is now read-only.
Add counters to outputComputePlan#74
Merged
thibaultrobert merged 3 commits intomasterfrom Jan 20, 2020
Merged
Conversation
thibaultrobert
requested review from
camillemarini and
inelgnu
as code owners
inelgnu
previously approved these changes
Jan 20, 2020
Member
inelgnu
left a comment
inelgnu
left a comment
There was a problem hiding this comment.
LGTM, I think it would better to have some consistency between input and output on 'TupleCount' 'TuplesCount' field, but it's minor.
thibaultrobert
force-pushed
the
add-counters
branch
from
a533e41 to
eaa6174
Compare
thibaultrobert
force-pushed
the
add-counters
branch
from
eaa6174 to
5addc25
Compare
inelgnu
approved these changes
Jan 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.