Skip to content
This repository was archived by the owner on Sep 6, 2022. It is now read-only.

Correct errors#78

Merged
thibaultrobert merged 5 commits intomasterfrom
correct-errors
Jan 27, 2020
Merged

Correct errors#78
thibaultrobert merged 5 commits intomasterfrom
correct-errors

Conversation

@thibaultrobert
Copy link
Contributor

Fixes #77

Copy link
Contributor

@samlesu samlesu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thibaultrobert thibaultrobert merged commit ad501f7 into master Jan 27, 2020
@thibaultrobert thibaultrobert deleted the correct-errors branch January 27, 2020 15:52
samlesu pushed a commit to Substra/substra-backend that referenced this pull request Jan 29, 2020
This is possible thanks to this update in the chaincode: Substra/substra-chaincode#78
samlesu pushed a commit to Substra/substra-backend that referenced this pull request Jan 29, 2020
This is possible thanks to this update in the chaincode: Substra/substra-chaincode#78
thibaultrobert added a commit that referenced this pull request Feb 11, 2020
* Specify bad request error

* Use Internal when possible

* Clean leftover in utils

* Fix after reviews

* BadRequest for DAG
thibaultrobert added a commit that referenced this pull request Feb 11, 2020
* Refacto compute plan count

* Update chaincode/testtuple.go upon review

Co-Authored-By: Aurélien Gasser <aurelien.gasser@owkin.com>

* Correct errors (#78)

* Specify bad request error

* Use Internal when possible

* Clean leftover in utils

* Fix after reviews

* BadRequest for DAG

* Use directly the expected asset type

Co-authored-by: Aurélien Gasser <aurelien.gasser@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Chaincode returns 500 error instead of 400 in some cases

3 participants