Skip to content

feat: add client.login_with_token#349

Closed
oleobal wants to merge 1 commit into
mainfrom
feat/login-token
Closed

feat: add client.login_with_token#349
oleobal wants to merge 1 commit into
mainfrom
feat/login-token

Conversation

@oleobal
Copy link
Copy Markdown
Contributor

@oleobal oleobal commented Mar 10, 2023

Summary

This PR adds Client.login_with_token method, which is an alternative to Client.login. Instead of calling a backend endpoint to get a token, just directly use a token.

This is intended for use as part of the single-sign on scheme: SSO users have no password, so they cannot use the current login method. Instead, they will manually retrieve a bearer token and use it with Client.login_with_token.

Open questions:

  • maybe it should be use_token (or log_in_with_token)
  • maybe we should try contacting the API to make sure the token works

Please check if the PR fulfills these requirements

  • If necessary, the changelog has been updated
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The commit message follows the conventional commit specification
  • For any breaking changes, companion PRs have been opened on the following repositories:

Signed-off-by: Olivier Léobal <olivier.leobal@owkin.com>
@oleobal
Copy link
Copy Markdown
Contributor Author

oleobal commented Mar 16, 2023

Superfluous

@oleobal oleobal closed this Mar 16, 2023
@oleobal oleobal deleted the feat/login-token branch March 16, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant