feat: update following the metric change in substratools#24
Merged
Conversation
louishulot
approved these changes
Sep 22, 2022
|
|
||
| - Update the Client, it takes a backend type instead of debug=True + env variable to set the spawner - (#210) | ||
| - Do not use Model.category since this field is being removed from the SDK | ||
| - Update the tests and benchmark with the change on Metrics from substratools (#24) |
Contributor
There was a problem hiding this comment.
It has been decided with Romain that all notable changes within the whole API should be mention here under a
Notable Changes due to substra-tools title
Comment on lines
+21
to
+24
| # TODO: revert before merge | ||
| # DEFAULT_SUBSTRATOOLS_VERSION = ( | ||
| # f"latest-nvidiacuda11.6.0-base-ubuntu20.04-python{sys.version_info.major}.{sys.version_info.minor}" | ||
| # ) |
Esadruhn
force-pushed
the
metrics_to_generic
branch
from
e8c3681 to
0709a64
Compare
Esadruhn
force-pushed
the
metrics_to_generic
branch
from
0709a64 to
c4ca833
Compare
Contributor
Author
|
|
Signed-off-by: thaisdeboisfosse <thais.de-boisfosse@owkin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Substra/substra-tools#60
Related issue
#followed by the number of the issueSummary
Notes
Please check if the PR fulfills these requirements