Skip to content

chore: remove test only from Datasamples #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThibaultFy merged 2 commits into from
Jan 17, 2023
Merged

chore: remove test only from Datasamples #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b21afa
rm test only
ThibaultFy Dec 23, 2022
5154b96
changelog
ThibaultFy Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## \[Unreleased\]

### Removed

- Test only field for datasamples (#67)

### Changed

- feat: remove RemoteDataMethod and change RemoteMethod class to be fully flexible regarding function name.
The substra-tools methods is now generic, and load the inputs depending on the inputs dictionary content (#59)

Expand Down
1 change: 0 additions & 1 deletion benchmark/camelyon/pure_substrafl/register_assets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ def add_duplicated_dataset(

data_sample = DataSampleSpec(
data_manager_keys=[dataset_key],
test_only=kind == "test",
path=data_sample_folder,
)

Expand Down
3 changes: 1 addition & 2 deletions tests/assets_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ def add_numpy_samples(
) -> List[str]:
"""Each client will associated one element of the contents list (pairs are made according to their respective index)
with the corresponding dataset key and submit it to substra. The content will be stored in the tmp_folder in the
process. All the samples will be added with the argument `test_only=False`
process.

Args:
contents (List[np.ndarray]): Numpy contents to add to each organization.
Expand Down Expand Up @@ -134,7 +134,6 @@ def add_numpy_samples(

data_sample_spec = DataSampleSpec(
data_manager_keys=[dataset_key],
test_only=False,
path=data_sample_folder,
)

Expand Down