Fix Piper Linux espeak symlink#10769
Merged
niksedk merged 1 commit intoMay 4, 2026
Merged
Conversation
f1a5494 to
258ad66
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Piper download flow on Linux so the unpacked engine gets the expected shared-library symlinks via .NET file APIs instead of shelling out to ln. It fits into the UI text-to-speech download pipeline by adjusting DownloadTtsViewModel, which prepares the locally installed Piper runtime before the engine is used.
Changes:
- Added a Linux symlink mapping for
libespeak-ng.so.1alongside the existinglibpiper_phonemize.so.1mapping. - Replaced the shell-based symlink creation logic with
File.CreateSymbolicLinkplus explicit cleanup of existing paths. - Added a focused unit test that verifies the Piper Linux symlink mapping contains both expected library entries.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/ui/Features/Video/TextToSpeech/DownloadTts/DownloadTtsViewModel.cs |
Refactors Linux Piper symlink setup and adds the missing libespeak-ng mapping. |
tests/UI/Features/Video/TextToSpeech/DownloadTts/DownloadTtsViewModelTests.cs |
Adds a regression test that checks the exported Linux symlink mapping. |
258ad66 to
5681afa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
libespeak-ng.so.1after unpacking Piper.libpiper_phonemize.so.1symlink behavior and use version-independent*.so.1.*source matching so future Piper archive bumps do not require exact filename updates.ln -sfstyle behavior vialn -sfn, so existing or dangling symlinks are replaced instead of blocking setup.ln -sfncommand.Addresses discussion #10659.
Verification
#10659,libespeak-ng.so.1, and Piper symlink wording; did not find an active duplicate.dotnet test .\tests\UI\UITests.csproj -c Debug --no-restore --filter DownloadTtsViewModelTests -v minimalpassed: 3/3.dotnet build .\src\ui\UI.csproj -c Debug --no-restoresucceeded.dotnet test .\tests\UI\UITests.csproj -c Debug --no-restore -v minimalpassed: 127/127.Notes