Fix "Adjust timings" always re-checked in STT post-processing#11282
Merged
Conversation
The post-processing dialog wrote WhisperAutoAdjustTimings directly, but the main view model keeps a stale in-memory mirror (DoAdjustTimings) that SaveSettings() writes back on close, clobbering the user choice. Sync the mirror when the dialog is accepted. Fixes #11275 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the Speech-to-text post-processing dialog so the “Adjust timings” checkbox state persists correctly and is not overwritten by the parent view model’s stale in-memory setting.
Changes:
- Syncs
DoAdjustTimingsfrom the post-processing dialog value when OK is pressed. - Keeps subsequent
SaveSettings()calls from clobberingWhisperAutoAdjustTimings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@
Fixes #11275
Problem
In the Speech-to-text post-processing dialog, every option remembers its last state on reopen except Adjust timings, which is always checked.
Root cause
The "Adjust timings" setting (
WhisperAutoAdjustTimings) is mirrored by an in-memory propertyDoAdjustTimingson the mainSpeechToTextViewModel:LoadSettings()loads it from the setting when the window opens.SaveSettings()writes it back to the setting on close.Unlike the other post-processing options,
DoAdjustTimingshas no checkbox on the main window — the only place to toggle it is the post-processing dialog, which writes the setting directly and never updatesDoAdjustTimings. So after the user unchecks it in the dialog, the main windows staleDoAdjustTimings(defaulttrue) overwrites the setting again on the nextSaveSettings(), and the box reappears checked.Fix
When the post-processing dialog is accepted, also sync the in-memory mirror so it cant clobber the user choice.
🤖 Generated with Claude Code
@