Add editable whitelist for "Remove if all uppercase" (#11563)#11968
Merged
niksedk merged 2 commits intoJun 29, 2026
Conversation
) "Remove text for hearing impaired" → "Remove if all uppercase" deleted short all-caps lines like "OK", "WWE" and other acronyms, because the keep-list was hardcoded (YES/NO/WHY/HI/OK + single char) and not user-editable. Replace the hardcoded list with a configurable, comma-separated whitelist (default "YES, NO, WHY, HI, OK, TV, OK.") surfaced as a text box next to the "If line is uppercase" checkbox. All-uppercase lines that match the whitelist (case-insensitive) are kept; single-letter lines such as "I" are always kept. Wired through libse (RemoveTextForHISettings / RemoveTextForHI, plus the persisted RemoveTextForHearingImpairedSettings default) and the SE5 settings/ view-model/window, so it benefits the dialog and the batch-convert path.
The new "keep these words" tooltip now respects Se.Settings.Appearance.ShowHints like the rest of the UI. Also removed "OK." from the default whitelist - the matcher trims trailing '.' before comparing, so "OK." could never match. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11563.
Problem: 'Remove text for hearing impaired' → 'Remove if all uppercase' deleted short all-caps lines like
OK,WWEand other acronyms, because the keep-list was hardcoded (YES/NO/WHY/HI/OK+ single char) and not user-editable.Fix: replace the hardcoded list with a configurable, comma-separated whitelist (default
YES, NO, WHY, HI, OK, TV, OK.) shown as a text box next to the 'If line is uppercase' checkbox. All-uppercase lines matching the whitelist (case-insensitive) are kept; single-letter lines likeIare always kept.Wired through libse (
RemoveTextForHISettings/RemoveTextForHI+ the persisted default) and the SE5 settings/view-model/window, so it benefits both the dialog and batch convert.