Closed
Conversation
- Add missing SkiaSharp NuGet package dependency (SubtitleEdit#9956) - Remove stray '.dll' command from build.bat line 13 (SubtitleEdit#9957) - Fix UpdateAssemblyInfo.exe path to use Release build output (SubtitleEdit#9958) Fixes for clean builds on Windows 11 with VS 2022. 🤖 Generated with Claude Code (claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
|
Could you change it to remove Skia? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes three build errors that prevent Subtitle Edit from building cleanly on Windows.
Issues Fixed
Changes
Test Environment
build.bat rebuildAll changes are minimal and focused on fixing the specific build issues without altering functionality.
🤖 Generated with Claude Code