Ensure we pass url ignore and other parameters, silently discarding now#87
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the da_build composite action to forward URL-check–related inputs (skip-url-check, skip-templates, ignore-urls) into the main python -m dayamlchecker invocation, instead of silently ignoring them in that step.
Changes:
- Build a bash
argsarray in the “Run YAML Checker” step based on action inputs. - Pass those arguments through to
python -m dayamlcheckerwhen linting*/questions/*.yml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if [ -n "${{ inputs.ignore-urls }}" ]; then | ||
| args+=(--url-check-ignore-urls "${{ inputs.ignore-urls }}") | ||
| fi |
There was a problem hiding this comment.
@copilot apply changes based on this feedback
There was a problem hiding this comment.
Fixed in 215bcdf. Both the "Run YAML Checker" and "Check URLs in question/template files" steps now declare SKIP_URL_CHECK, SKIP_TEMPLATES, and IGNORE_URLS under env: and reference them as $SKIP_URL_CHECK, $SKIP_TEMPLATES, and $IGNORE_URLS in the shell scripts, eliminating the direct ${{ inputs.xxx }} interpolation.
…ent command injection Agent-Logs-Url: https://github.com/SuffolkLITLab/ALActions/sessions/78ea72fc-6e6b-408a-9683-624ed558179e Co-authored-by: nonprofittechy <7645641+nonprofittechy@users.noreply.github.com>
No description provided.