Add tests, format with black and fix type issues#10
Merged
nonprofittechy merged 8 commits intomainfrom Feb 26, 2026
Merged
Conversation
nonprofittechy
changed the title
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive test coverage and improves type annotations across the codebase. The changes align with a move toward better type safety using mypy and modernized testing practices.
Changes:
- Added type annotations to multiple modules (generate_mcp_config.py, code_formatter.py, yaml_structure.py)
- Added new test files for CLI functionality (_collect_yaml_files function)
- Refactored _collect_yaml_files to be shared between yaml_structure and code_formatter modules
- Simplified CI workflow to use ALActions
- Added requirements.txt with project dependencies including mypy
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/generate_mcp_config.py | Added type annotations for packaged_main variable and main function return type |
| tests/test_yaml_structure_cli.py | New test file for _collect_yaml_files function in yaml_structure module |
| tests/test_code_formatter_cli.py | New test file for _collect_yaml_files function in code_formatter module |
| tests/test_code_formatter.py | Updated quote style in name check to match codebase convention |
| src/dayamlchecker/yaml_structure.py | Removed duplicate _collect_yaml_files implementation, now delegates to code_formatter; added type annotations; added type: ignore comments for untyped imports |
| src/dayamlchecker/mcp/server.py | Added type: ignore comment for untyped mcp import |
| src/dayamlchecker/generate_mcp_config.py | Added comprehensive type annotations and JSON validation for args parameter |
| src/dayamlchecker/code_formatter.py | Added type annotations; refactored to use CommentedMap/CommentedSeq instead of generic dict/list; improved formatting consistency |
| requirements.txt | New file listing project dependencies including mypy |
| .github/workflows/ci-checker.yml | Simplified workflow to use ALActions/pythontests action |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.