Implement PythonBool validator for mandatory, initial, scan for variables#41
Merged
Conversation
BryceStevenWilley
approved these changes
May 27, 2026
Collaborator
BryceStevenWilley
left a comment
BryceStevenWilley
left a comment
There was a problem hiding this comment.
Looks good to me, one small change to scan for variables needed, but the feature itself looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PythonBoolwas a stub class with no validation. This implements it to catch cases where attributes likemandatory,initial, andscan for variablesare set to invalid values like numbers or non-Python strings. Added tests covering valid and invalid cases for all three attributes.Valid values:
True,False, or a Python expression likeuser_age > 18Invalid values: numbers like
10, strings like"yes please",null