Fix API key permissions#35
Merged
Merged
Conversation
BryceStevenWilley
requested changes
May 28, 2026
BryceStevenWilley
left a comment
BryceStevenWilley
left a comment
There was a problem hiding this comment.
Code looks good, but testing it doesn't actually fix the error: should hook into the /manage_api endpoint, I'm not sure if do_api_user_api() is called from there or not.
|
Perfect, that fix did seem to work! |
BryceStevenWilley
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a new API key, Docassemble lets you select permissions during creation but they were dropped silently - add_api_key function had no permissions parameter and the POST handler never read them from the request.
This fix adds permissions support to add_api_key and adds the same permissions validation to the POST handler that already existed in the PATCH handler, so permissions set at creation time are now saved correctly. This is a prerequisite for contributing #24 upstream.
Closes #33