Adding Code to lambda for AWS Observability #117
Conversation
…tor is created, install the MetaData Source for EC2. Do not fetch the existing collector and source, as it will be deleted when CF template is deleted.
…e and one without role. Role ARN can be provided to attach to Lambda Function. Also, creating lambda function with a name.
…C and ALB AWS Resources.
|
|
||
| return {"TAG_CREATION": "Successful"}, "Tag" | ||
|
|
||
| def update(self, region_value, aws_resource, tags, account_id, filter_regex, *args, **kwargs): |
There was a problem hiding this comment.
what happens to the old tag when we create the new ones during update? will the stay as it is? Is it documented?
There was a problem hiding this comment.
It is documented in AWS Observability docs. We don't have a functionality doc for Sumo App utils.
There was a problem hiding this comment.
and customers are ok if the old tags remain as it is?
There was a problem hiding this comment.
We do not ask for Tags from Customers. We just take the value. So, we do not change the Key for tags just the value.
But yes, in general it can be improved, if we keep track of old tag keys that were passed.
There was a problem hiding this comment.
cool then we should add this to observability improvement backlog jira so that it can tracked.
| response = self.sumologic_cli.import_content(personal_folder_id, content, is_overwrite="true") | ||
|
|
||
| if "AWS Observability" in appname: | ||
| folder_id = self._create_or_fetch_quickstart_apps_parent_folder("Sumo Logic AWS Observability Apps ") |
There was a problem hiding this comment.
is this a recursive function? Also can we remove the "Sumo Logic AWS Observability Apps" thing similar to how we removed for "SumoLogic Amazon QuickStart Apps "?
There was a problem hiding this comment.
Quick Start is present for folder naming. Similarly Observability is added for folder naming.
There was a problem hiding this comment.
Quickstart was removed as I can see in the diff can't we pass observability folder name as well. Asking this because this is a library(not just for aws observability) and should be generic.
There was a problem hiding this comment.
QuickStart is present but Yes, we can make it generic.
There was a problem hiding this comment.
quickstart is also present I thought you handled it using folder_prefix (see the githubdiff 605) seems then we'll have to create a backlog jira for this since it will require multiple changes.
There was a problem hiding this comment.
A new parameter as folder name should suffice, if it is present, then create that folder. I will track this in my tasks with AWS Observability
There was a problem hiding this comment.
cool then we should add this to observability improvement backlog jira so that it can tracked.
|
|
||
| # Field Extraction Rule can be updated and deleted from the main stack where it was created. | ||
| def update(self, fer_id, fer_name, fer_scope, fer_expression, fer_enabled, *args, **kwargs): | ||
| data, fer_id = self.create(fer_name, fer_scope, fer_expression, fer_enabled, *args, **kwargs) |
There was a problem hiding this comment.
what if someone changed the fer name, will the old FER still exists?
There was a problem hiding this comment.
ah. We should call update method here. I will update it in the next set of changes.
There was a problem hiding this comment.
cool then we should add this to observability improvement backlog jira so that it can tracked.
…s in PR - Include testing of all resources for updates scenario. Updated update method with scenarios. - Added description for Update fields custom resource. - Removed function name from YAMl - Added export for Role ARN.
No description provided.