[WIP] - Refactor Lambda #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumoroku
reviewed
Nov 11, 2016
| context.fail(e); | ||
| } | ||
|
|
||
| var awslogsData = JSON.parse(buffer.toString('ascii')); |
There was a problem hiding this comment.
is "ascii" the encoding? is that a safe assumption?
Contributor
Author
There was a problem hiding this comment.
Thing is, i didn't change it, that's how it was previously. should probably be utf8.
Contributor
There was a problem hiding this comment.
@kumoroku : it's base64 first. After that it seems to be ascii: http://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/SubscriptionFilters.html#LambdaFunctionExample
duchatran
reviewed
Nov 14, 2016
| lastRequestID = rs[1]; | ||
| } | ||
| val.requestID = lastRequestID; | ||
| val.logStream = stream; |
Contributor
There was a problem hiding this comment.
@stevezau : we need to make logStream and logGroup on by default, otherwise data sent by this function will not be compatible with our Lambda app.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR is to refactor the lambda function.
Updates