Fixing Region bucket mapping #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duchatran
suggested changes
Dec 21, 2018
Contributor
duchatran
left a comment
duchatran
left a comment
There was a problem hiding this comment.
LGTM, optional request. I leave it up to you to use appdevstore or sumologic-appdevstore.
| "Type": "AWS::Lambda::Function", | ||
| "Properties": { | ||
| "Code": { | ||
| "S3Bucket": "appdevstore", |
Contributor
There was a problem hiding this comment.
I created a bucket called "sumologic-appdevstore". You can use this to make it look more official
Contributor
Author
There was a problem hiding this comment.
Yes agreed let's migrate rest of the functions as well in separate PR
himanshu219
force-pushed
the
hpal_bucket_fix
branch
from
64debf8 to
52b2524
Compare
himanshu219
force-pushed
the
hpal_bucket_fix
branch
from
52b2524 to
3ef7cba
Compare
himanshu219
force-pushed
the
hpal_bucket_fix
branch
from
cb76a78 to
7f9f5f5
Compare
himanshu219
force-pushed
the
hpal_bucket_fix
branch
2 times, most recently
from
d641453 to
f0b79a0
Compare
himanshu219
force-pushed
the
hpal_bucket_fix
branch
from
f0b79a0 to
ae0d628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.