Skip to content

Conversation

@himanshu219
Copy link
Contributor

No description provided.

Copy link
Contributor

@duchatran duchatran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change needed.

for i in "${regions[@]}"
do
echo "Deploying layer in $i"
bucket_name="appdevzipfiles-$i"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should change regions to an explicit map in case someone already claimed a bucket with the same format for a new region.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to find a better way for escaping strings in associated arrays in bash script.

@himanshu219 himanshu219 force-pushed the sechub_timestamp_fix branch from f16162a to 4dcf7c8 Compare April 16, 2019 10:11
@himanshu219 himanshu219 force-pushed the sechub_timestamp_fix branch from 4dcf7c8 to 7c6f28f Compare April 16, 2019 12:19
@himanshu219 himanshu219 merged commit 4ec3ab2 into master Apr 16, 2019
@himanshu219 himanshu219 deleted the sechub_timestamp_fix branch June 12, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants