Skip to content

Conversation

@akesle
Copy link
Contributor

@akesle akesle commented Feb 12, 2025

Purpose of this pull request

Bring Sumo Logic's Fastly integration VCL examples in line with Fastly's own documentation for integrating with Sumo Logic. This concerns the preferred use of the VCL json.escape function over the somewhat ineffective (in the context of JSON) use of the suggested cstr_escape.

TL:DR Using cstr_escape in a Fastly VCL log format string may still result in invalid JSON sequences, whereas substituting json.escape will alleviate all those issues.

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

Originated by Fastly.

@cla-bot
Copy link

cla-bot bot commented Feb 12, 2025

Thank you for your contribution! As this is an open source project, we require contributors to sign our Contributor License Agreement and do not have yours on file. To proceed with your PR, please sign your name here and we will add you to our approved list of contributors.

@akesle
Copy link
Contributor Author

akesle commented Feb 12, 2025

Thank you for your contribution! As this is an open source project, we require contributors to sign our Contributor License Agreement and do not have yours on file. To proceed with your PR, please sign your name here and we will add you to our approved list of contributors.

I have signed this license agreement.

Copy link
Collaborator

@jpipkin1 jpipkin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, @akesle.

@jpipkin1 jpipkin1 mentioned this pull request Feb 12, 2025
4 tasks
@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Feb 12, 2025
@jpipkin1 jpipkin1 enabled auto-merge February 12, 2025 23:23
@akesle
Copy link
Contributor Author

akesle commented Feb 12, 2025

Approved, @akesle.

Much appreciated, @jpipkin1 👋

@jpipkin1 jpipkin1 added this pull request to the merge queue Feb 12, 2025
Merged via the queue into SumoLogic:main with commit 4f1e912 Feb 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor approved, listed in .clabot file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants