-
Notifications
You must be signed in to change notification settings - Fork 228
Add env var syntax deprecation note to 12 OpenTelemetry app docs #5448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… variable syntax in opentelemetry collector syntax
…ariable in case of linux env) is optional
docs/integrations/databases/opentelemetry/cassandra-opentelemetry.md
Outdated
Show resolved
Hide resolved
docs/integrations/containers-orchestration/opentelemetry/rabbitmq-opentelemetry.md
Outdated
Show resolved
Hide resolved
docs/integrations/databases/opentelemetry/cassandra-opentelemetry.md
Outdated
Show resolved
Hide resolved
docs/integrations/databases/opentelemetry/oracle-opentelemetry.md
Outdated
Show resolved
Hide resolved
docs/integrations/databases/opentelemetry/redis-opentelemetry.md
Outdated
Show resolved
Hide resolved
docs/integrations/databases/opentelemetry/oracle-opentelemetry.md
Outdated
Show resolved
Hide resolved
docs/integrations/databases/opentelemetry/oracle-opentelemetry.md
Outdated
Show resolved
Hide resolved
docs/integrations/databases/opentelemetry/redis-opentelemetry.md
Outdated
Show resolved
Hide resolved
docs/integrations/databases/opentelemetry/oracle-opentelemetry.md
Outdated
Show resolved
Hide resolved
docs/integrations/databases/opentelemetry/oracle-opentelemetry.md
Outdated
Show resolved
Hide resolved
docs/integrations/databases/opentelemetry/oracle-opentelemetry.md
Outdated
Show resolved
Hide resolved
docs/integrations/databases/opentelemetry/oracle-opentelemetry.md
Outdated
Show resolved
Hide resolved
kimsauce
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sumoanema , many thanks for your PR! I converted your note into a reusable reference, and then insert it in each doc. Does this look OK?
|
@kimsauce - So there are certain apps for which username and password are optional, these apps are JMX, activeMQ, cassandra, apache tomcat . for the rest it should be : What do you suggest, how should we make changes for it ? |
Hi @sumoanema , thank you for clarifying! Ok, I've created two separate reusable versions of the note ( |
|
Looks good to me @kimsauce |
OK! just approved |
JV0812
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of this pull request
Adding a note for 12 opentelemetry app docs, after deprecation of env variable syntax in opentelemetry collector syntax
Select the type of change
Ticket (if applicable)