Skip to content

pr.yml test for disallowed character checks #5891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Oct 9, 2025
Merged

pr.yml test for disallowed character checks #5891

merged 22 commits into from
Oct 9, 2025

Conversation

@kimsauce
Copy link
Collaborator

@kimsauce kimsauce commented Oct 8, 2025 •
edited
Loading

Purpose of this pull request

TEST: For site migration to Pantheon, certain characters are disallowed in links (this includes legacy cid-redirects). Currently, Pantheon only catches disallowed characters in production workflows.

This PR edits pr.yml for disallowed character checks so they're caught in dev.

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

https://sumologic.atlassian.net/browse/DOCS-1182

@kimsauce kimsauce self-assigned this Oct 8, 2025
@kimsauce kimsauce requested review from a team, JV0812, amee-sumo, jpipkin1 and mafsumo as code owners October 8, 2025 18:30
@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Oct 8, 2025
@kimsauce kimsauce marked this pull request as draft October 8, 2025 18:31
@kimsauce kimsauce added the do-not-merge Pull requests that should not be merged label Oct 8, 2025
kimsauce
kimsauce commented Oct 8, 2025
View reviewed changes
kimsauce
kimsauce commented Oct 8, 2025
View reviewed changes
kimsauce
kimsauce commented Oct 8, 2025
View reviewed changes
@kimsauce
Update cid-redirects.json
7b56a9e 
Test vertical bar '|'
kimsauce
kimsauce commented Oct 8, 2025
View reviewed changes
kimsauce
kimsauce commented Oct 8, 2025
View reviewed changes
kimsauce
kimsauce commented Oct 8, 2025
View reviewed changes
kimsauce
kimsauce commented Oct 8, 2025
View reviewed changes
@kimsauce kimsauce requested a review from vfalconisumo October 8, 2025 20:51
@kimsauce kimsauce marked this pull request as ready for review October 8, 2025 20:51
@kimsauce kimsauce marked this pull request as draft October 8, 2025 20:57
@kimsauce kimsauce marked this pull request as ready for review October 8, 2025 23:51
kimsauce
kimsauce commented Oct 8, 2025
View reviewed changes
kimsauce
kimsauce commented Oct 9, 2025
View reviewed changes
@kimsauce kimsauce removed the do-not-merge Pull requests that should not be merged label Oct 9, 2025
@kimsauce kimsauce enabled auto-merge October 9, 2025 02:14
@kimsauce kimsauce added this pull request to the merge queue Oct 9, 2025
Merged via the queue into main with commit 872d07f Oct 9, 2025
7 checks passed
@kimsauce kimsauce deleted the disallowed-char branch October 9, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpipkin1 jpipkin1 Awaiting requested review from jpipkin1 jpipkin1 is a code owner

@JV0812 JV0812 Awaiting requested review from JV0812 JV0812 is a code owner

@mafsumo mafsumo Awaiting requested review from mafsumo mafsumo is a code owner

@amee-sumo amee-sumo Awaiting requested review from amee-sumo amee-sumo is a code owner

@vfalconisumo vfalconisumo Awaiting requested review from vfalconisumo

Assignees

@kimsauce kimsauce

Labels

cla-signed Contributor approved, listed in .clabot file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kimsauce