Add feature switch for JSON log enhancement #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lacer93
changed the title
|
@himanshu219 please take a look when you can. |
himanshu219
reviewed
Sep 8, 2022
| } else { | ||
| item["message"] = json | ||
| if s.config.EnhanceJsonLogs { | ||
| item = json |
There was a problem hiding this comment.
shouldn't it be opposite if enhance json logs is true then item["message"] = json else item = json
There was a problem hiding this comment.
Oh, that's correct. Fixing it.
SumoLogic#13 Implement a feature switch to turn off log enhancement for JSON logs Feature switch defaults to `true`, so behaviour is unchanged
lacer93
force-pushed
the
enhance-json-logs-feature-switch
branch
from
ac32200 to
2b31f95
Compare
himanshu219
approved these changes
Sep 8, 2022
|
@himanshu219 thanks for the merge. Should I make a new release with it or is that your responsibility? |
|
release is done automatically via github actions I will push the new tag |
|
@himanshu219 do you have an ETA for that? |
|
new release is published. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13
Implement a feature switch to turn off log enhancement for JSON logs
Feature switch defaults to
true, so behaviour is unchangedPR Details
Add a feature switch to turn off log enhancement for JSON logs
Description
Implement a feature switch (via the enrivonment variable
SUMO_ENHANCE_JSON_LOGS) which defaults totrueso current behaviour remains unchanged. If the feature switch is set tofalsethen the message sent to SumoLogic will not contain any addition metadata only the actual log message.Related Issue
#13
Checklist