-
Notifications
You must be signed in to change notification settings - Fork 8
Sumo 270861: Enhacement extension for CVE fixes #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4cd1b49 to
169fb61
Compare
169fb61 to
8be657e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades Go to version 1.24 and implements comprehensive error handling improvements as part of CVE fixes. The main changes include proper error handling for resource cleanup, AWS SDK v2 migration, and golangci-lint fixes.
- Upgraded Go from 1.22 to 1.24 with enhanced toolchain support
- Migrated AWS SDK from v1 to v2 for better security and performance
- Enhanced error handling throughout the codebase with proper resource cleanup
Reviewed Changes
Copilot reviewed 19 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Go version upgrade to 1.24 and AWS SDK v2 migration |
| lambda-extensions/workers/producer.go | Enhanced error handling for HTTP request body cleanup |
| lambda-extensions/workers/consumer.go | Code cleanup and simplified string conversion |
| lambda-extensions/utils/utils.go | Added error returns to compression functions |
| lambda-extensions/utils/awsutils.go | Migrated to AWS SDK v2 with proper error handling |
| lambda-extensions/sumologic-extension.go | Added context parameters and error handling |
| lambda-extensions/sumoclient/sumoclient.go | Comprehensive error handling improvements |
| lambda-extensions/config/version.go | Layer version increment |
| containerimageexample/python-arm64/* | Updated Python version and build configuration |
| .github/workflows/unittest.yml | Go version update and AWS credentials configuration |
| Multiple test files | Enhanced error handling in test cleanup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Details
Description
Related Issue
https://sumologic.atlassian.net/browse/SUMO-270861
Checklist