feat: enforce Moderator role via flag_disputed_pool#1
Merged
Sundriveauto merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
- Add Disputed = 3 variant to MarketState enum - Add PoolDisputedEvent (pool_id, moderator, reason) - Add DataKey::Disputed(u64) storage key - Add PoolDisputed = 27 to PrediFiError enum - Implement flag_disputed_pool gated by require_role(caller, 2) - Add tests: moderator succeeds, unauthorized fails, resolved pool fails Closes Web3Novalabs#595
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the Moderator role enforcement (issue Web3Novalabs#595).
Disputed = 3variant toMarketStateenumPoolDisputedEvent(pool_id, moderator, reason)DataKey::Disputed(u64)persistent storage keyPoolDisputed = 27toPrediFiErrorenumflag_disputed_poolgated byrequire_role(caller, Role::Moderator)(role 2)Acceptance Criteria
Tests
test_flag_disputed_pool_moderator_succeeds— moderator can flag an active pooltest_flag_disputed_pool_unauthorized_fails— non-moderator is rejectedtest_flag_disputed_pool_already_resolved_fails— non-active pool is rejected